test(starlette): Verify request info captured with POST endpoints#6269
Open
alexander-alderman-webb wants to merge 4 commits into
Open
test(starlette): Verify request info captured with POST endpoints#6269alexander-alderman-webb wants to merge 4 commits into
alexander-alderman-webb wants to merge 4 commits into
Conversation
Contributor
Codecov Results 📊✅ 282 passed | Total: 282 | Pass Rate: 100% | Execution Time: 41.56s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 14775 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 33.63% 33.63% —%
==========================================
Files 190 190 —
Lines 22260 22260 —
Branches 7536 7536 —
==========================================
+ Hits 7485 7485 —
- Misses 14775 14775 —
- Partials 747 747 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d91d454. Configure here.
sentrivana
approved these changes
May 18, 2026
Contributor
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
Looking great! So much better than unit testing the internal request extractor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace tests that directly call
StarletteRequestExtractorwith tests that assert that request info is captured on errors and transaction events when appropriate POST endpoints are called.Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)